fix(prometheus.echo): Return zero for SeriesRef#5622
Merged
Conversation
jharvey10
approved these changes
Feb 23, 2026
Draft
jharvey10
pushed a commit
that referenced
this pull request
Feb 26, 2026
### Brief description of Pull Request Make sure prometheus.echo always returns zero for SeriesRefs. The current implementation will return an non-zero unstable SeriesRef which will interfere with the implementation of #5062. This component shouldn't be returning a SeriesRef as it's not creating or managing one and when it's the only component in use in a pipeline this will prevent unnecessary overhead to manage these unstable refs in fanout + prometheus.scrape. ### Issue(s) fixed by this Pull Request Related to #5062 ### PR Checklist - [x] Tests updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description of Pull Request
Make sure prometheus.echo always returns zero for SeriesRefs. The current implementation will return an non-zero unstable SeriesRef which will interfere with the implementation of #5062. This component shouldn't be returning a SeriesRef as it's not creating or managing one and when it's the only component in use in a pipeline this will prevent unnecessary overhead to manage these unstable refs in fanout + prometheus.scrape.
Issue(s) fixed by this Pull Request
Related to #5062
PR Checklist