feat: Update github exporter with github app authentication#5377
feat: Update github exporter with github app authentication#5377
Conversation
|
💻 Deploy preview deleted (feat: Update github exporter with github app authentication). |
🔍 Dependency ReviewBelow is an assessment of the Go module dependency changes in this PR, focusing only on entries changed in go.mod files. For each changed dependency, I outline potential code changes needed to safely adopt the new version and include supporting evidence. github.com/githubexporter/github-exporter v0.0.0-20231025122338-656e7dc33fe7 → v1.3.1 —
|
docs/sources/reference/components/prometheus/prometheus.exporter.github.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/prometheus/prometheus.exporter.github.md
Show resolved
Hide resolved
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
kgeckhart
left a comment
There was a problem hiding this comment.
Non-blocking suggestion
| hasTokenAuth := c.APIToken != "" || c.APITokenFile != "" | ||
| hasGitHubAppAuth := c.GitHubAppID != 0 && c.GitHubAppInstallationID != 0 && c.GitHubAppKeyPath != "" |
There was a problem hiding this comment.
Should we check for misconfiguration GithubApp auth like if they missed setting one of these? Maybe logging the auth strategy identified could help instead? Thinking about how we could make a user error less frustrating to identify.
Brief description of Pull Request
Update the github exporter packaged in Alloy including support for Github App authentication.
Pull Request Details
Issue(s) fixed by this Pull Request
Notes to the Reviewer
PR Checklist