Skip to content

Add 'failOnModifiedDerivedModuleNames' option#189

Merged
jjohannes merged 2 commits into
mainfrom
failOnModifiedDerivedModuleNames
Jul 11, 2025
Merged

Add 'failOnModifiedDerivedModuleNames' option#189
jjohannes merged 2 commits into
mainfrom
failOnModifiedDerivedModuleNames

Conversation

@jjohannes

@jjohannes jjohannes commented Jul 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

This option is for library developers to make sure they do not use modified names of Jars without module-info and without Automatic-Module-Name.

Motivated by this discussion: APIdia-net/apidia.net#2 (comment)

TODO:

  • Tests: option on -> fail, option on but overrideModuleName() used -> no fail
  • Changelog

@jjohannes jjohannes added this to the 1.13 milestone Jul 9, 2025
@jjohannes jjohannes self-assigned this Jul 9, 2025
@jjohannes jjohannes mentioned this pull request Jul 9, 2025
Merged
4 tasks
@koppor

koppor commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

Maybe you can test this at JabRef/jabref#13521? ( ghpr checkout 13521)

@jjohannes jjohannes force-pushed the failOnModifiedDerivedModuleNames branch 3 times, most recently from 97640f2 to c5f539f Compare July 11, 2025 09:24
@jjohannes jjohannes force-pushed the failOnModifiedDerivedModuleNames branch from c5f539f to 149be7a Compare July 11, 2025 09:31
@jjohannes jjohannes merged commit 5df1c54 into main Jul 11, 2025
1 check passed
@jjohannes jjohannes deleted the failOnModifiedDerivedModuleNames branch July 11, 2025 09:52
@jjohannes

jjohannes commented Jul 11, 2025

Copy link
Copy Markdown
Member Author

@koppor this is released in 1.13. Please update and add failOnModifiedDerivedModuleNames = true to your build setup to use this in the linked PR.

@koppor

koppor commented Jul 11, 2025

Copy link
Copy Markdown
Contributor

I'll do 😅

Can I remove failOnAutomaticModules = true for some more "magic"? At JabRef/jabref#13313 our contributor had difficulties adding depdencies.

@koppor koppor mentioned this pull request Jul 11, 2025
Merged
1 task
@jjohannes

jjohannes commented Jul 11, 2025

Copy link
Copy Markdown
Member Author

If you remove failOnAutomaticModules = true the plugin no longer informs you about Jars that miss a module-info.class. Then jpakackage will fail later - it can't work with those Jars. That's why you probably want to keep it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jjohannes jjohannes

Labels

None yet

Projects

None yet

Milestone

1.13

Development

Successfully merging this pull request may close these issues.

2 participants

@jjohannes @koppor