Disable repositories more often and add property to continue when disabled#36060
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7828618 to
8eb7122
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Also adjust test to clarify when Gradle disables and when it does not.
This is used to indicate that the build should not fail if the repository cannot handle dependency resolution requests.
8eb7122 to
7bf8a13
Compare
big-guy
previously requested changes
Dec 18, 2025
7bf8a13 to
eec58bf
Compare
eec58bf to
b59fc00
Compare
big-guy
reviewed
Dec 18, 2025
| local = new ErrorHandlingModuleComponentRepositoryAccess(delegate.getLocalAccess(), getId(), RepositoryDisabler.NoOpDisabler.INSTANCE, getName()); | ||
| remote = new ErrorHandlingModuleComponentRepositoryAccess(delegate.getRemoteAccess(), getId(), remoteRepositoryDisabler, getName()); | ||
| this.remoteRepositoryDisabler = remoteRepositoryDisabler; | ||
| local = new ErrorHandlingModuleComponentRepositoryAccess(delegate.getLocalAccess(), getId(), RepositoryDisabler.NoOpDisabler.INSTANCE, getName(), false); |
Member
There was a problem hiding this comment.
Does it make sense to say that the local part never continues (false) or that it always continues (true) or should it match the remote part? I'm not entirely sure myself since the local side can never be disabled.
Member
Author
There was a problem hiding this comment.
I think leaving it as false is good for now. But the whole error handling thing should be redefined for the local part. While there are common IOException, most of the logic makes little sense for local. And with proper handling, we might be able to do better errors. But let's do that in a different PR.
lkasso
approved these changes
Dec 18, 2025
This improves reproducibility of builds by making sure Gradle does not check the next repository in the list when the current one fails to answer.
Includes release notes entry
…pository DefaultUrlArtifactRepository is really about holding information about the URL and not a repository itself.
b59fc00 to
9bcf1f4
Compare
Member
Author
|
@bot-gradle test RfR |
This comment has been minimized.
This comment has been minimized.
big-guy
reviewed
Dec 18, 2025
|
|
||
| @Override | ||
| public boolean isRepositoryDisabled() { | ||
| return remoteRepositoryDisabler.isDisabled(getId()) || delegate.isRepositoryDisabled(); |
Member
There was a problem hiding this comment.
If I'm following this correctly, delegate.isRepositoryDisabled is always false. The only way for it to not be false is if remoteRepositoryDisabler.isDisabled is true.
It looks like ExternalResourceResolver is the only real implementation. Could it get a RepositoryDisabler and have it check isDisabled in isRepositoryDisabled?
Member
|
@bot-gradle test RfR |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
The following builds have been cancelled: |
Collaborator
|
The following builds have passed: |
This was referenced Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on top of 36059
It is a draft because there is still some work that needs to be done in disabling repos more aggressively.Repositories are now also disabled if the max retry is reached for transient connection errors. This improves build reproducibility.
A new property can be configured per repository to indicate if a disabled repository should still allow resolution to continue.