Skip to content

[prone] fix NPE apply UndefinedEquals#35662

Merged
ov7a merged 1 commit into
gradle:masterfrom
Pankraz76:pr-UndefinedEquals-all
Nov 14, 2025
Merged

[prone] fix NPE apply UndefinedEquals#35662
ov7a merged 1 commit into
gradle:masterfrom
Pankraz76:pr-UndefinedEquals-all

Conversation

@Pankraz76

Copy link
Copy Markdown

Context

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

@bot-gradle bot-gradle added from:contributor PR by an external contributor to-triage labels Nov 13, 2025

@Pankraz76 Pankraz76 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 ct.

kindly request @ov7a if you got some off time. Thanks.

@Pankraz76 Pankraz76 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix NPE.

@ov7a ov7a left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Apart from the comment below, LGTM

@ov7a ov7a added in:building-gradle gradle/gradle build and removed to-triage labels Nov 14, 2025
@Pankraz76

Copy link
Copy Markdown
Author

adjusted wrong commit msg, sorry for that.

Signed-off-by: Vincent Potucek <vpotucek@me.com>
@ov7a ov7a marked this pull request as ready for review November 14, 2025 12:34
@ov7a ov7a requested a review from a team as a code owner November 14, 2025 12:34
@ov7a ov7a requested a review from octylFractal November 14, 2025 12:34
@ov7a ov7a added this pull request to the merge queue Nov 14, 2025
@bot-gradle bot-gradle added this to the 9.3.0 RC1 milestone Nov 14, 2025
Merged via the queue into gradle:master with commit 81c54ce Nov 14, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:contributor PR by an external contributor in:building-gradle gradle/gradle build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants