Skip to content

[prone] Apply UndefinedEquals#35609

Merged
ov7a merged 1 commit into
gradle:masterfrom
Pankraz76:pr-UndefinedEquals
Nov 12, 2025
Merged

[prone] Apply UndefinedEquals#35609
ov7a merged 1 commit into
gradle:masterfrom
Pankraz76:pr-UndefinedEquals

Conversation

@Pankraz76

@Pankraz76 Pankraz76 commented Nov 9, 2025

Copy link
Copy Markdown

Context

@ov7a

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

@bot-gradle bot-gradle added from:contributor PR by an external contributor to-triage labels Nov 9, 2025
@Pankraz76

Copy link
Copy Markdown
Author

item:

ConfigureByMapActionTest > equality FAILED
org.spockframework.runtime.SpockComparisonFailure at ConfigureByMapActionTest.groovy:98

@ov7a ov7a self-assigned this Nov 12, 2025
@ov7a ov7a removed the to-triage label Nov 12, 2025
Comment thread subprojects/core/build.gradle.kts
Comment thread subprojects/core/src/main/java/org/gradle/api/internal/ConfigureByMapAction.java Outdated
@ov7a ov7a added the in:building-gradle gradle/gradle build label Nov 12, 2025
@ov7a ov7a removed request for a team, 6hundreds and abstratt November 12, 2025 13:12
Signed-off-by: Vincent Potucek <vpotucek@me.com>

@ov7a ov7a left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ov7a ov7a added this pull request to the merge queue Nov 12, 2025
@bot-gradle bot-gradle added this to the 9.3.0 RC1 milestone Nov 12, 2025
Merged via the queue into gradle:master with commit deb4002 Nov 12, 2025
20 checks passed
@ov7a ov7a mentioned this pull request Nov 14, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:contributor PR by an external contributor in:building-gradle gradle/gradle build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants