Skip to content

Fix precompiled script plugin name generation#35051

Merged
blindpirate merged 1 commit into
releasefrom
reinhold/fix-precompiled-plugin-name-generation
Sep 25, 2025
Merged

Fix precompiled script plugin name generation#35051
blindpirate merged 1 commit into
releasefrom
reinhold/fix-precompiled-plugin-name-generation

Conversation

@reinsch82

@reinsch82 reinsch82 commented Sep 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes

The class keyword in the @file annotation causes the optimization we have to hit to early.
See the comment, why LBRACE is a good fix for this.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

@reinsch82 reinsch82 linked an issue Sep 19, 2025 that may be closed by this pull request
Precompiled script plugin with @file annotation loses package and breaks #34101
Closed
@reinsch82 reinsch82 marked this pull request as ready for review September 19, 2025 12:18
@reinsch82 reinsch82 requested a review from a team as a code owner September 19, 2025 12:18
@reinsch82 reinsch82 requested a review from eskatos September 19, 2025 12:18
donat
donat requested changes Sep 22, 2025
View reviewed changes

@donat donat left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We reviewed it in a pairing session and it all makes sense. Only a bit of context missing. Please add some comments so that the next person has an easier time understanding why we changed the token list.

Comment thread ...rc/main/kotlin/org/gradle/kotlin/dsl/provider/plugins/precompiled/PrecompiledScriptPlugin.kt
Comment thread ...est/kotlin/org/gradle/kotlin/dsl/provider/plugins/precompiled/PrecompiledScriptPluginTest.kt
@reinsch82 reinsch82 force-pushed the reinhold/fix-precompiled-plugin-name-generation branch from 6625afe to 5495e3b Compare September 22, 2025 08:14
@reinsch82 reinsch82 requested a review from donat September 22, 2025 08:15
@reinsch82 reinsch82 enabled auto-merge September 22, 2025 08:17
@reinsch82 reinsch82 self-assigned this Sep 22, 2025
@reinsch82 reinsch82 added this pull request to the merge queue Sep 22, 2025
@bot-gradle bot-gradle added this to the 9.2.0 RC1 milestone Sep 22, 2025
@cobexer cobexer removed this pull request from the merge queue due to a manual request Sep 22, 2025
@cobexer cobexer modified the milestones: 9.2.0 RC1, 9.3.0 RC1 Sep 22, 2025
@reinsch82 reinsch82 changed the base branch from master to release September 22, 2025 09:38
@reinsch82 reinsch82 added this pull request to the merge queue Sep 24, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 24, 2025
@blindpirate blindpirate added this pull request to the merge queue Sep 25, 2025
Merged via the queue into release with commit fac6a92 Sep 25, 2025
35 checks passed
@blindpirate blindpirate deleted the reinhold/fix-precompiled-plugin-name-generation branch September 25, 2025 05:22
@reinsch82 reinsch82 mentioned this pull request Sep 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eskatos eskatos eskatos approved these changes

@donat donat donat approved these changes

Assignees

@reinsch82 reinsch82

Labels

None yet

Projects

None yet

Milestone

9.2.0 RC1

Development

Successfully merging this pull request may close these issues.

Precompiled script plugin with @file annotation loses package and breaks

6 participants

@reinsch82 @eskatos @donat @cobexer @blindpirate @bot-gradle