Skip to content

S1144: Unused "private" methods should be removed#34905

Merged
ov7a merged 1 commit into
gradle:masterfrom
Pankraz76:merge-fm
Sep 9, 2025
Merged

S1144: Unused "private" methods should be removed#34905
ov7a merged 1 commit into
gradle:masterfrom
Pankraz76:merge-fm

Conversation

@Pankraz76

@Pankraz76 Pankraz76 commented Sep 5, 2025 •
edited
Loading

Copy link
Copy Markdown

Context

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

happy ci:

related to:

S1144: Unused "private" methods should be removed
8b3334b 
Signed-off-by: Vincent Potucek <vpotucek@me.com>
Co-authored-by: Vincent Potucek <vpotucek@me.com>
Signed-off-by: Vincent Potucek <vpotucek@me.com>
@bot-gradle bot-gradle added from:contributor PR by an external contributor to-triage labels Sep 5, 2025
@alllex alllex removed their request for review September 5, 2025 18:02
@ov7a ov7a self-assigned this Sep 8, 2025
@ov7a

ov7a commented Sep 9, 2025

Copy link
Copy Markdown
Member

@bot-gradle test this

@bot-gradle

This comment has been minimized.

Sign in to view
@bot-gradle

bot-gradle commented Sep 9, 2025

Copy link
Copy Markdown
Collaborator

The following builds have failed:

@ov7a

ov7a commented Sep 9, 2025

Copy link
Copy Markdown
Member

Thank you for your contribution!

This PR is complete and simple enough, it will be merged immediately.

The following builds have failed:

These are false positives.

@ov7a ov7a added this pull request to the merge queue Sep 9, 2025
@bot-gradle bot-gradle added this to the 9.2.0 RC1 milestone Sep 9, 2025
@ov7a ov7a added in:building-gradle gradle/gradle build and removed to-triage labels Sep 9, 2025
Merged via the queue into gradle:master with commit a5a7ffd Sep 9, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@big-guy big-guy Awaiting requested review from big-guy big-guy is a code owner automatically assigned from gradle/bt-jvm

@asodja asodja Awaiting requested review from asodja asodja is a code owner automatically assigned from gradle/bt-cortex

Assignees

@ov7a ov7a

Labels

from:contributor PR by an external contributor in:building-gradle gradle/gradle build

Projects

None yet

Milestone

9.2.0 RC1

Development

Successfully merging this pull request may close these issues.

3 participants

@Pankraz76 @ov7a @bot-gradle