Re-enable Support for relative java installation paths for Daemon toolchain#32894
Merged
ljacomet merged 1 commit intoMar 9, 2026
Conversation
8bb25ca to
d117067
Compare
9 tasks
ljacomet
requested changes
Apr 1, 2025
d117067 to
f481333
Compare
Contributor
Author
Here are some changes based on the feedback provided:
|
9 tasks
Member
|
@vmadalin Sorry for the long delay. I rebased this and will be validating it locally before doing one last review. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
|
The following builds have failed: |
Signed-off-by: Madalin Valceleanu <vmadalin@google.com> (cherry picked from commit cf5f11231c4ed229bf7859d04267697838861619)
Member
|
@bot-gradle test RfN |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
The following builds have passed: |
ljacomet
approved these changes
Mar 9, 2026
ljacomet
left a comment
Member
There was a problem hiding this comment.
Did a final round of tests and working as expected.
✅
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Original changes #32869 have been reverted due to an issue about running Gradle inside the
libfolder of a generated (by Gradle init) library project, paths are evaluated relative to the execution location and not the folder containing settings. This has been fixed and a test was added to validate the mentioned scenarioContributor Checklist
<subproject>/src/integTest) to verify changes from a user perspective.<subproject>/src/test) to verify logic../gradlew sanityCheck../gradlew <changed-subproject>:quickTest.