Introduce methods to change SerializerRegistry used by test workers.#24088
Closed
dubinsky wants to merge 1 commit intogradle:masterfrom
dubinsky:override-worker-parameter-serializers
Closed
Introduce methods to change SerializerRegistry used by test workers.#24088dubinsky wants to merge 1 commit intogradle:masterfrom dubinsky:override-worker-parameter-serializers
dubinsky wants to merge 1 commit intogradle:masterfrom
dubinsky:override-worker-parameter-serializers
Conversation
Signed-off-by: Leonid Dubinsky <dub@podval.org>
Author
|
I found a workaround (encode additional information I need to get to the test worker into the class name before forking). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce methods to change SerializerRegistry used by test workers.
Context
I am working on a plugin that supports testing Scala and ScalaJS code using test frameworks that implement sbt.testing.Framework.
I need to convey to the test workers, in addition to the test class name, framework-specific information obtained during test discovery. To do that, I need to use a parameter serializer other than the currently hard-coded TestEventSerializer.
Proposed change satisfies this need; without it, I will have to include in my plugin modified versions of the three Gradle classes - hundreds of lines of code!
Contributor Checklist
<subproject>/src/integTest) to verify changes from a user perspective<subproject>/src/test) to verify logic./gradlew sanityCheck./gradlew <changed-subproject>:quickTestGradle Core Team Checklist