Skip to content

Run codenarc in worker#21417

Merged
bot-gradle merged 1 commit intomasterfrom
jvandort/run-codenarc-in-worker
Aug 15, 2022
Merged

Run codenarc in worker#21417
bot-gradle merged 1 commit intomasterfrom
jvandort/run-codenarc-in-worker

Conversation

@jvandort
Copy link
Copy Markdown
Member

@jvandort jvandort commented Aug 2, 2022 •
edited
Loading

Runs CodeNarc in a Worker. Based off of previous work done for checkstyle

  • Write tests
  • Figure out how to configure logging for worker
  • Link toolchain with that set in java plugin
  • Update release notes

@jvandort jvandort force-pushed the jvandort/run-codenarc-in-worker branch from 4d02747 to 55fe3c6 Compare August 2, 2022 03:03
@jvandort jvandort self-assigned this Aug 3, 2022
@jvandort jvandort added this to the 7.6 RC1 milestone Aug 3, 2022
@jvandort jvandort requested a review from a team August 3, 2022 00:28
big-guy
big-guy requested changes Aug 3, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@big-guy big-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also try running some of the "all versions" tests that only run under Ready For Release: https://builds.gradle.org/viewType.html?buildTypeId=Gradle_Master_Check_AllVersionsIntegMultiVersion_33_bucket6

This will run all of the supported versions of CodeNarc

@jvandort jvandort force-pushed the jvandort/run-codenarc-in-worker branch from 5725a97 to cfc8e2f Compare August 3, 2022 23:02
@jvandort
Copy link
Copy Markdown
Member Author

jvandort commented Aug 3, 2022

All version test results:
https://builds.gradle.org/buildConfiguration/Gradle_Master_Check_AllVersionsIntegMultiVersion_33_bucket6/54605976?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildChangesSection=true

@jvandort jvandort modified the milestones: 7.6 RC1, 8.0 RC1 Aug 11, 2022
@jvandort jvandort force-pushed the jvandort/run-codenarc-in-worker branch 2 times, most recently from 81cf735 to c635565 Compare August 12, 2022 21:52
@jvandort jvandort marked this pull request as ready for review August 12, 2022 21:52
@jvandort jvandort requested review from big-guy and tresat August 12, 2022 21:52
@jvandort jvandort force-pushed the jvandort/run-codenarc-in-worker branch from c635565 to 0614476 Compare August 12, 2022 22:03
tresat
tresat approved these changes Aug 15, 2022
View reviewed changes
@jvandort jvandort force-pushed the jvandort/run-codenarc-in-worker branch 3 times, most recently from 441e332 to abff002 Compare August 15, 2022 18:23
@jvandort
Copy link
Copy Markdown
Member Author

jvandort commented Aug 15, 2022

@bot-gradle test this

@gradle gradle deleted a comment from jvandort Aug 15, 2022
@bot-gradle
Copy link
Copy Markdown
Collaborator

bot-gradle commented Aug 15, 2022

OK, I've already triggered the following builds for you:

@jvandort jvandort force-pushed the jvandort/run-codenarc-in-worker branch from abff002 to a9cee55 Compare August 15, 2022 19:57
@jvandort
Copy link
Copy Markdown
Member Author

jvandort commented Aug 15, 2022

@bot-gradle test and merge

@gradle gradle deleted a comment from jvandort Aug 15, 2022
@bot-gradle
Copy link
Copy Markdown
Collaborator

bot-gradle commented Aug 15, 2022

OK, I've already triggered a build for you.

@bot-gradle bot-gradle merged commit 9897e95 into master Aug 15, 2022
@blindpirate blindpirate deleted the jvandort/run-codenarc-in-worker branch August 16, 2022 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tresat tresat tresat approved these changes

@nathan-contino nathan-contino Awaiting requested review from nathan-contino

@big-guy big-guy Awaiting requested review from big-guy

Assignees

@jvandort jvandort

Labels

None yet

Projects

None yet

Milestone

8.0 RC1

Development

Successfully merging this pull request may close these issues.

4 participants

@jvandort @bot-gradle @tresat @big-guy