Add memory config to checkstyle#20198
Merged
bot-gradle merged 8 commits intogradle:masterfrom Mar 18, 2022
Merged
Conversation
With having ported the Checkstyle task to use the worker api we see OOM problems with our elasticsearch build when using the latest gradle master (7.5 snapshot) This PR makes the heap size for checkstyle tasks configurable to not be forced to rely on jdk defaults. The property namings are similar to how memory settings are named in the Test task. Signed-off-by: Rene Groeschke <rene@elastic.co>
Signed-off-by: Rene Groeschke <rene@elastic.co>
e4518df to
5a9392e
Compare
Signed-off-by: Rene Groeschke <rene@elastic.co>
Member
|
@bot-gradle test this |
Collaborator
|
OK, I've already triggered the following builds for you: |
wolfs
reviewed
Mar 18, 2022
subprojects/core-api/src/main/java/org/gradle/process/JavaForkOptions.java
Outdated
Show resolved
Hide resolved
…Options.java Apply suggested javadoc tweaks Co-authored-by: Stefan Wolf <wolf@gradle.com> Signed-off-by: Rene Groeschke <rene@elastic.co>
19f0999 to
8ed734d
Compare
290e19f to
831fbaf
Compare
Member
|
@bot-gradle test and merge |
Collaborator
|
OK, I've already triggered a build for you. |
Member
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Out of memory issues when running checkstyle against large sourceSets
Context
With having ported the Checkstyle task to use the worker api and running in a separate java process (#20069) we see OOM problems
with our elasticsearch build when using the latest gradle master (7.5 snapshot)
This PR makes the heap size for checkstyle tasks configurable to not be forced to
rely on jdk defaults.
The property namings are similar to how memory settings are named in the Test task.
Contributor Checklist
<subproject>/src/integTest) to verify changes from a user perspective<subproject>/src/test) to verify logic./gradlew sanityCheck./gradlew <changed-subproject>:quickTestGradle Core Team Checklist