Skip to content

Fix race condition with fetching short lived token#260

Merged
cdsap merged 1 commit into
mainfrom
atual/fix-await
Jun 17, 2024
Merged

Fix race condition with fetching short lived token#260
cdsap merged 1 commit into
mainfrom
atual/fix-await

Conversation

@alextu

@alextu alextu commented Jun 17, 2024

Copy link
Copy Markdown
Contributor

This somehow worked before (and in our integ test) because the setup action gave enough time to let the request short-lived token return in time 🤷.

This caused a race condition not allowing the short-lived token to be returned in time before the setup finished.
@alextu alextu requested review from bigdaz and cdsap June 17, 2024 17:03
@github-actions

Copy link
Copy Markdown
Contributor

Job Summary for Gradle

Demo adding Build Scan® comment to PR :: failing-build-with-comment-on-failure
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
kotlin-dsl no-a-real-task 8.8 Build Scan published

@github-actions

Copy link
Copy Markdown
Contributor

Job Summary for Gradle

Demo adding Build Scan® comment to PR :: successful-build-with-always-comment
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
kotlin-dsl build 8.8 Build Scan published

@github-actions

Copy link
Copy Markdown
Contributor

Job Summary for Gradle

Demo adding Build Scan® comment to PR :: failing-build-with-comment-on-failure
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
kotlin-dsl no-a-real-task 8.8 Build Scan published

@github-actions

Copy link
Copy Markdown
Contributor

Job Summary for Gradle

Demo adding Build Scan® comment to PR :: successful-build-with-always-comment
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
kotlin-dsl build 8.8 Build Scan published

@cdsap cdsap merged commit ae74429 into main Jun 17, 2024
@cdsap cdsap deleted the atual/fix-await branch June 17, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants