Improve build scan badge readability with long tasks#200
Merged
Conversation
Signed-off-by: Gabriel Feo <gabriel@gabrielfeo.com>
Signed-off-by: Gabriel Feo <gabriel@gabrielfeo.com>
Change tests for nbsp and concise badge Make tests pass Signed-off-by: Gabriel Feo <gabriel@gabrielfeo.com>
Member
Author
|
Here's how tables render in the end (just the HTML from the unit tests):
|
Member
|
Thanks for the PR and for adding some test coverage. Much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve readability of build scan when requested tasks is very long, as agreed in #175. HTML diff for each case of job summary is clearer in cd62d9c.
Also fix a typo in the build shell script.