Skip to content

Use Gradle logger instead of println in dependency graph init script#191

Merged
bigdaz merged 2 commits into
gradle:mainfrom
aleksandrserbin:main
Apr 19, 2024
Merged

Use Gradle logger instead of println in dependency graph init script#191
bigdaz merged 2 commits into
gradle:mainfrom
aleksandrserbin:main

Conversation

@aleksandrserbin

Copy link
Copy Markdown
Contributor

Dependency graph generation script should respect gradle's logger settings. For example, when -q supplied, "Generating dependency graph into" message should not be printed

@bgalek

bgalek commented Apr 19, 2024

Copy link
Copy Markdown

@bigdaz please take a look, this is a big improvement for us :)

@bigdaz bigdaz merged commit 6ccde15 into gradle:main Apr 19, 2024
@bigdaz bigdaz added this to the v3.4 milestone Apr 19, 2024
@bgalek

bgalek commented Apr 19, 2024

Copy link
Copy Markdown

@bigdaz thank you! You are super responsive :)

@bgalek

bgalek commented Apr 19, 2024

Copy link
Copy Markdown

@bigdaz, are you interested in our company usage of this action?
We're migrating ~1500 repositories now ;)

@bigdaz

bigdaz commented Apr 19, 2024

Copy link
Copy Markdown
Member

@bgalek Yes I'm very interested in how you're doing it and what your experience is. Please share as much as you can. DM me if that's preferable.

We are just starting to promote the project: https://blog.gradle.org/gradle-github-partnership-supply-chain-security
Note that resolving alerts isn't always straightforward:

@bigdaz

bigdaz commented Apr 19, 2024

Copy link
Copy Markdown
Member

The Gradle Community Slack is a good place to discuss: https://gradle.org/slack-invite

@bgalek

bgalek commented Apr 19, 2024

Copy link
Copy Markdown

I'll catch you there than :)

@bgalek

bgalek commented Apr 25, 2024

Copy link
Copy Markdown

@bigdaz do You have a v3.3.2 release date? :)

@bigdaz bigdaz changed the title Use logger in dependency graph init script Use Gradle logger instead of println in dependency graph init script Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants