Skip to content

Ruff update + strictening#3979

Merged
abidlabs merged 19 commits into
gradio-app:mainfrom
akx:ruff-ext2
Apr 28, 2023
Merged

Ruff update + strictening#3979
abidlabs merged 19 commits into
gradio-app:mainfrom
akx:ruff-ext2

Conversation

@akx

@akx akx commented Apr 26, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR removes some of the ignores left in the ruff config in #3710, making the configuration stricter (thus catching more bugs).

It fixes those issues where possible, and adds a couple of noqas where it was hard to tell what would be the right fix.

Each commit is quite atomic and can be reviewed separately.

Checklist:

  • I have performed a self-review of my own code
  • I have added a short summary of my change to the CHANGELOG.md
  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@gradio-pr-bot

gradio-pr-bot commented Apr 26, 2023

Copy link
Copy Markdown
Collaborator

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-3979-all-demos

@akx akx force-pushed the ruff-ext2 branch 4 times, most recently from 0ec50ca to dd25f00 Compare April 27, 2023 05:53
@akx akx marked this pull request as ready for review April 27, 2023 06:19
@akx akx mentioned this pull request Apr 27, 2023
Merged
7 tasks
@akx akx marked this pull request as draft April 27, 2023 19:54
akx added 17 commits April 28, 2023 08:47
@akx
Update ruff to 0.0.263
23d2879
@akx
Get rid of bare except:s
99590fe
@akx
Fix two Ruff E731s by moving expand_{color,size} to the relevant classes
bbb2b24
@akx
Fix Ruff E731 and some variable shadowing in theme builder
71f5f8a
@akx
Fix remaining Ruff E731s
d3c0cfe
@akx
Get rid of unused Ruff ignores
ebaca4f
@akx
Fix ruff B904 issues (raise from)
9ac7054
@akx
Fix Ruff B007: loop-control variable not used
502c56a
@akx
Fix Ruff B011 (do not assert false)
308a35e
@akx
Remove unused args and kwargs from Progress.tqdm() (spotted via Ruff …
fa08aa0 
…B026)
@akx
Fix mutable argument default in CheckboxGroup
43738db
@akx
Noqa ABC-related lint warnings for Interpretable
b87dcf7
@akx
Add missed assert in test_queueing (ruff B015)
54d1bda
@akx
Enable ruff B
f05c63c
@akx
Enable ruff C and fix issues
3a5548d
@akx
Add changelog
94f77e6
@akx
Add UP03[012] after gradio-app#3984
3ab19a3
@akx akx marked this pull request as ready for review April 28, 2023 05:53
abidlabs
abidlabs approved these changes Apr 28, 2023
View reviewed changes

@abidlabs abidlabs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, @akx! Thanks for cleaning up so many disparate issues. LGTM

Will merge once we can get CI green

@abidlabs

abidlabs commented Apr 28, 2023

Copy link
Copy Markdown
Member

Will merge as flaky tests are unrelated and are also happening on main

@abidlabs abidlabs merged commit 12a9774 into gradio-app:main Apr 28, 2023
This was referenced May 4, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abidlabs abidlabs abidlabs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akx @gradio-pr-bot @abidlabs