Skip to content

Fixes dropdown does not position itself at selected element when opened#3639

Merged
dawoodkhan82 merged 6 commits into
mainfrom
dropdown_scroll
Apr 25, 2023
Merged

Fixes dropdown does not position itself at selected element when opened#3639
dawoodkhan82 merged 6 commits into
mainfrom
dropdown_scroll

Conversation

@dawoodkhan82

@dawoodkhan82 dawoodkhan82 commented Mar 27, 2023

Copy link
Copy Markdown
Collaborator

Description

Fixes issue: dropdown does not position itself at selected element when opened
Also fixes issue with remove all button not hiding when no option is selected.

Please include:

  • relevant motivation
  • a summary of the change
  • which issue is fixed.
  • any additional dependencies that are required for this change.

Closes: #3559

Checklist:

  • I have performed a self-review of my own code
  • I have added a short summary of my change to the CHANGELOG.md
  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

A note about the CHANGELOG

Hello 👋 and thank you for contributing to Gradio!

All pull requests must update the change log located in CHANGELOG.md, unless the pull request is labeled with the "no-changelog-update" label.

Please add a brief summary of the change to the Upcoming Release > Full Changelog section of the CHANGELOG.md file and include
a link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by [@myusername](link-to-your-github-profile) in [PR 11111](https://github.com/gradio-app/gradio/pull/11111)".

If you would like to elaborate on your change further, feel free to include a longer explanation in the other sections.
If you would like an image/gif/video showcasing your feature, it may be best to edit the CHANGELOG file using the
GitHub web UI since that lets you upload files directly via drag-and-drop.

@gradio-pr-bot

Copy link
Copy Markdown
Collaborator

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-3639-all-demos

Comment thread ui/packages/form/src/DropdownOptions.svelte

@aliabd aliabd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abidlabs abidlabs requested a review from pngwn April 24, 2023 16:48

@pngwn pngwn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Sorry for the delay on this one!

@dawoodkhan82

Copy link
Copy Markdown
Collaborator Author

Thanks for the review @pngwn @aliabd. Will merge when tests pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gr.Dropdown does not position itself at selected element when opened

5 participants