Add proivded dependencies on classpath#714
Merged
Conversation
melix
previously approved these changes
Apr 11, 2025
Collaborator
melix
left a comment
There was a problem hiding this comment.
Would be good to add a test for this.
melix
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #601 and #562
I tested this on the
java-application-with-resourcessample. If I set<scope>oforg.apache.commonstoprovided:and there is no
org.apache.commonsdependency.and we can see that there is an entry for
org.apache.commons(/.m2/repository/org/apache/commons/commons-lang3/3.12.0/commons-lang3-3.12.0.jar)NOTE: when I run
mvn -Pnative package -DskipNativeTestsclasspath doesn't haveorg.apache.commonsdependency if it has<scope>provided</scope>:(without explicitly defined
<scope>the dependency appears on classpath)