Skip to content

Fix workflow trigger#682

Merged
dnestoro merged 1 commit intograalvm:masterfrom
melix:cc/issue-670
Feb 18, 2025
Merged

Fix workflow trigger#682
dnestoro merged 1 commit intograalvm:masterfrom
melix:cc/issue-670

Conversation

@melix
Copy link
Collaborator

@melix melix commented Jan 22, 2025

Fixes #670

@dnestoro I think the issue comes from the fact that we should use the names of the workflows, not their ids, in the list.

@melix melix requested a review from dnestoro January 22, 2025 13:16
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 22, 2025
@dnestoro
Copy link
Contributor

@melix my question is why we trigger this workflow like this? Why we don't trigger it when something is merged with master? We do the same in the metadata repository, here

@melix
Copy link
Collaborator Author

melix commented Jan 22, 2025

I think it's done so that we only publish snapshots for successful pipeline. This would be to avoid that a snapshot from a broken master is published. But that's only a guess.

@dnestoro
Copy link
Contributor

But we are performing checks before anything gets merged into master, right? So if we pass those checks, the master should be in the correct state? Or I am missing some edge case?

@melix
Copy link
Collaborator Author

melix commented Jan 22, 2025

I don't think this was the case when this workflow was created.

@dnestoro
Copy link
Contributor

Aha, okay. So should we keep this approach with workflows or we want to switch to the strategy we use in metadata repo? What do you think is the better solution in this case? I am fine with both

@melix
Copy link
Collaborator Author

melix commented Jan 22, 2025

Both are probably ok, I have no preference either. Let's see if this one works.

@dnestoro dnestoro merged commit eb42788 into graalvm:master Feb 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[QUESTION] Pre-release/ snapshot repository unavailable?

2 participants