Merged
Conversation
Contributor
Collaborator
Author
|
I think it's done so that we only publish snapshots for successful pipeline. This would be to avoid that a snapshot from a broken master is published. But that's only a guess. |
Contributor
|
But we are performing checks before anything gets merged into master, right? So if we pass those checks, the master should be in the correct state? Or I am missing some edge case? |
Collaborator
Author
|
I don't think this was the case when this workflow was created. |
Contributor
|
Aha, okay. So should we keep this approach with |
Collaborator
Author
|
Both are probably ok, I have no preference either. Let's see if this one works. |
dnestoro
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #670
@dnestoro I think the issue comes from the fact that we should use the names of the workflows, not their ids, in the list.