Conversation
melix
approved these changes
Jan 6, 2025
Collaborator
melix
left a comment
There was a problem hiding this comment.
I think the issue is less that it can be accessed at the same milliseconds, than the fact that the Java clock for System.currentTimeMillis() doesn't guarantee anything and can return the same ms in 2 subsequent invocations separated by more than a ms.
3a0fd26 to
1e17965
Compare
This was referenced Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that our previous implementation with
millisecondsdoesn't work because there is still a chance that two threads can make an access-filter-file within the same millisecond.This PR replaces usage of milliseconds with nano time.
The PR fixes: #653 and #626