Skip to content

Improve GraalVM version check.#646

Merged
fniephaus merged 2 commits intograalvm:masterfrom
brunocaballero:master
Dec 9, 2024
Merged

Improve GraalVM version check.#646
fniephaus merged 2 commits intograalvm:masterfrom
brunocaballero:master

Conversation

@brunocaballero
Copy link
Contributor

@brunocaballero brunocaballero commented Dec 3, 2024

Fix for Issue #644

Building a native image with "non Oracle" GraalVM fails with the following error.

The problem was a regular expression.

$ mvn -Pnative package
...
[ERROR] Failed to execute goal org.graalvm.buildtools:native-maven-plugin:0.10.3:compile-no-fork (build-native) on project spring-boot-initial: Execution build-native of goal org.graalvm.buildtools:native-maven-plugin:0.10.3:compile-no-fork failed: Version to check 'native-image 23.0.1 2024-10-15
[ERROR] Java(TM) SE Runtime Environment MicroDoc GraalVM Embedded 23.0.1+11.1 (build 23.0.1+11-microdoc-p111200-t20241029n1-evaluation-linux-amd64-le-gcc11.2-gnu-glibc-jvmci-b01)
[ERROR] Java HotSpot(TM) 64-Bit Server VM MicroDoc GraalVM Embedded 23.0.1+11.1 (build 23.0.1+11-microdoc-p111200-t20241029n1-evaluation-linux-amd64-le-gcc11.2-gnu-glibc-jvmci-b01, mixed mode)' can't be parsed.

And for reference, here is the version reported by our native-image:

$ $JAVA_HOME/bin/native-image --version
native-image 23.0.1 2024-10-15
Java(TM) SE Runtime Environment MicroDoc GraalVM Embedded 23.0.1+11.1 (build 23.0.1+11-microdoc-p111200-t20241029n1-evaluation-linux-amd64-le-gcc11.2-gnu-glibc-jvmci-b01)
Java HotSpot(TM) 64-Bit Server VM MicroDoc GraalVM Embedded 23.0.1+11.1 (build 23.0.1+11-microdoc-p111200-t20241029n1-evaluation-linux-amd64-le-gcc11.2-gnu-glibc-jvmci-b01, mixed mode)

@oracle-contributor-agreement
Copy link

oracle-contributor-agreement bot commented Dec 3, 2024

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Dec 3, 2024
@dnestoro dnestoro requested review from melix and sdeleuze December 3, 2024 13:34
@brunocaballero
Copy link
Contributor Author

brunocaballero commented Dec 5, 2024

I made the OCA request, but it is still "under review" since 03.12.2024.

linghengqian
linghengqian reviewed Dec 6, 2024
View reviewed changes
Copy link
Contributor

@linghengqian linghengqian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the OCA request, but it is still "under review" since 03.12.2024.

  • @oracle-contributor-agreement 's github bot cannot automatically detect whether the OCA has been signed, you need to push the PR again.
  • To be honest, I don't know where to report bugs around @oracle-contributor-agreement . And there are not many places where @oracle-contributor-agreement can be used.

@oracle-contributor-agreement
Copy link

oracle-contributor-agreement bot commented Dec 6, 2024

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Dec 6, 2024
fniephaus
fniephaus approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@fniephaus fniephaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fniephaus fniephaus merged commit 355efa0 into graalvm:master Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdeleuze sdeleuze sdeleuze approved these changes

@melix melix melix approved these changes

@fniephaus fniephaus fniephaus approved these changes

+1 more reviewer

@linghengqian linghengqian linghengqian left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@brunocaballero @sdeleuze @melix @fniephaus @linghengqian