Fix error message when the JDK is not a GraalVM#616
Merged
Conversation
72797af to
a6afd71
Compare
Contributor
Author
|
I tried to fix the Gradle plugin in a similar manner. |
fniephaus
requested changes
Sep 2, 2024
...lugin/src/main/java/org/graalvm/buildtools/gradle/internal/NativeImageExecutableLocator.java
Outdated
Show resolved
Hide resolved
...lugin/src/main/java/org/graalvm/buildtools/gradle/internal/NativeImageExecutableLocator.java
Outdated
Show resolved
Hide resolved
...lugin/src/main/java/org/graalvm/buildtools/gradle/internal/NativeImageExecutableLocator.java
Outdated
Show resolved
Hide resolved
a6afd71 to
eb9a0e3
Compare
eb9a0e3 to
1f6d43d
Compare
fniephaus
approved these changes
Sep 3, 2024
dnestoro
reviewed
Sep 3, 2024
...lugin/src/main/java/org/graalvm/buildtools/gradle/internal/NativeImageExecutableLocator.java
Show resolved
Hide resolved
dnestoro
approved these changes
Sep 3, 2024
1f6d43d to
81fe799
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it still mentions
gubut that's gone and a misleading error.