refactor: move github api requests out of the way#711
Closed
panva wants to merge 1 commit intogr2m:masterfrom
panva:move-octokit.request
Closed
refactor: move github api requests out of the way#711panva wants to merge 1 commit intogr2m:masterfrom panva:move-octokit.request
panva wants to merge 1 commit intogr2m:masterfrom
panva:move-octokit.request
Conversation
gr2m
reviewed
Nov 14, 2024
Owner
gr2m
left a comment
There was a problem hiding this comment.
Looks good, thank you! But please remove the package-lock.json changes, that happens separately/automatically
Contributor
|
🎉 This issue has been resolved in version 1.10.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves octokit and making an authenticated request to a point after it is determined that a PR is going to be created or updated.