Added an option to skip pull request creation#704
Added an option to skip pull request creation#704lfgcampos wants to merge 1 commit intogr2m:masterfrom
Conversation
|
It does feel odd that creating a pull request is in the name of the action and then you can turn of that feature. I'm not sure about this one, I'd rather say it's out of scope |
I understand your concern and I am happy with your choice =) My use case is valid though and adding an extra action to commit a file while replacing this action (or using it for certain specific use cases only) is a route I would like to skip As you can see, the default param value will make sure the action work as is. But if this is something you won't consider anyway, feel free to close the PR then 🙁 |
Yeah sorry I think I'll pass. I think in an ideal world there would be an action to update multiple files in a branch which would use most of the logic in this action. And then this action would just create the pull request, basically split it up into two. But I don't have time to work on that unfortunately |
are you fine if I fork it then and adjust to my use case? |
For one of the use cases I have with this action, I would like to skip the PR creation based on a given parameter.
For example, when running this workflow against
masterormainbranch, I'd like to see a PR.But when running against a different branch, I would like to have my whole automation to run, have the branch creation, the commit but not a PR to avoid human mistake and unwanted merged.
Adding this option should cover this use case I have but also probably different use cases from the community.