Skip to content

Enable Adding Reviewers to PR#481

Closed
adzienis wants to merge 1 commit intogr2m:masterfrom
adzienis:add_reviewers
Closed

Enable Adding Reviewers to PR#481
adzienis wants to merge 1 commit intogr2m:masterfrom
adzienis:add_reviewers

Conversation

@adzienis
Copy link
Copy Markdown
Contributor

Hey, great overall GH action.

Just wanted to open a PR with a suggested feature of requesting reviewers. Added the relevant options (I believe), as well as added a test.

The test adds @gr2m as a requested reviewer, although not sure of any other dummy user to add as a reviewer (can't add the github actions bot as a test user).

Copy link
Copy Markdown
Owner

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Could you update the README as well, please?

@adzienis
Copy link
Copy Markdown
Contributor Author

Updated README.md to reference reviewers as an option.

@gr2m gr2m mentioned this pull request Dec 22, 2021
@gr2m gr2m closed this in #482 Dec 22, 2021
@gr2m
Copy link
Copy Markdown
Owner

gr2m commented Dec 22, 2021

Thanks @adzienis! I had to start a separate PR from a local branch for the tests to work.

@github-actions
Copy link
Copy Markdown
Contributor

🎉 This issue has been resolved in version 1.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants