Skip to content

Update the title and body when PR exists#353

Closed
gkuga wants to merge 6 commits intogr2m:masterfrom
gkuga:feature/update-pr
Closed

Update the title and body when PR exists#353
gkuga wants to merge 6 commits intogr2m:masterfrom
gkuga:feature/update-pr

Conversation

@gkuga
Copy link
Copy Markdown

@gkuga gkuga commented Dec 2, 2021

This PR addresses #309 and has breaking change.

gr2m
gr2m reviewed Dec 2, 2021
View reviewed changes
Copy link
Copy Markdown
Owner

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please update .github/workflows/test.yml to test the new functionality?

@gkuga gkuga force-pushed the feature/update-pr branch from 4e49f59 to e4fcedb Compare December 20, 2021 06:00
@gkuga
Copy link
Copy Markdown
Author

gkuga commented Dec 20, 2021

@gr2m Could you check the test for me? I think the following part will be !(steps.run.outputs.pull-request-number > 0).

create-or-update-pull-request-action/.github/workflows/test.yml

Line 31 in d344e35

- if: ${{ steps.run.outputs.result != 'updated' || steps.run.outputs.pull-request-number > 0 }}

create-or-update-pull-request-action/.github/workflows/test.yml

Line 62 in d344e35

- if: ${{ steps.run.outputs.pull-request-number > 0 }}

@gr2m gr2m self-assigned this Dec 21, 2021
@gr2m
Copy link
Copy Markdown
Owner

gr2m commented Dec 21, 2021

@gr2m Could you check the test for me? I think the following part will be !(steps.run.outputs.pull-request-number > 0).

Agreed! But something odd is going on here. When I change it to !(steps.run.outputs.pull-request-number > 0) it is still evaluated as steps.run.outputs.pull-request-number > 0, without the negation:

https://github.com/gr2m/create-or-update-pull-request-action/runs/4599942375?check_suite_focus=true#step:9:2

I'll investigate some more and file a ticket with GitHub

@gr2m
Copy link
Copy Markdown
Owner

gr2m commented Dec 21, 2021

okay never mind, I realized that while I worked on a pull request, the actions that were executed were still form the default branch. I think the problem is with thepull_request_target trigger. Now with the approve runs flow I can change it back to pull_request which should checkout the correct branch, I hope

gkuga and others added 3 commits December 21, 2021 13:19
@gr2m
Update the title and body when pr exists
94d97c4
@gr2m
Update action.yml
6c47d77 
Co-authored-by: Gregor Martynus <39992+gr2m@users.noreply.github.com>
@gr2m
Change variable name
4f2731c
@gr2m gr2m force-pushed the feature/update-pr branch from 76e1f64 to a79ba5c Compare December 21, 2021 21:20
@gr2m gr2m mentioned this pull request Dec 21, 2021
Merged
@gr2m gr2m force-pushed the feature/update-pr branch from a79ba5c to dbcf3b5 Compare December 21, 2021 21:27
@gr2m gr2m closed this in #416 Dec 21, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 21, 2021

🎉 This issue has been resolved in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gr2m gr2m gr2m left review comments

Assignees

@gr2m gr2m

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gkuga @gr2m