fix: webhook verification using a constant-time comparison#2
Merged
Conversation
gr2m
reviewed
Sep 6, 2022
Owner
gr2m
left a comment
There was a problem hiding this comment.
This is great, thank you so much!
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Owner
|
Any guidance on how to resolve this deploy error?
|
Contributor
Author
|
oh yeah, just do what the error says. Add to wrangler.toml like here |
Contributor
Author
|
This just enables all possibly breaking changes before that date that are listed on https://developers.cloudflare.com/workers/platform/compatibility-dates/. |
Owner
|
LOoks like we are back in business, thank you! The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found that splitting the private key into 3 parts is no longer necessary.
Also the
wranglerCLI is now available under thewranglerpackage, and the deploy action has a new version. Both simplify thewrangler.tomla bit.I've also taken the liberty to convert the worker.js to the new module workers format.
Also, this implements webhook verification using a constant-time comparison
fixes: #1