Subtract position from Vulkan inter stage limits #4518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Previews, as seen when this build job started (77e2669): |
kainino0x
previously approved these changes
Mar 15, 2024
Contributor
kainino0x
left a comment
There was a problem hiding this comment.
Oops, good catch. LGTM, matches my summary of the investigation/proposal. (Suggested edits to point directly at it.)
kainino0x
reviewed
Mar 15, 2024
Contributor
|
@teoxoy didn't the fixes that Jiawei did to the counting a while ago fix this issue such that we can close this PR? |
Member
Author
|
I think we still need to subtract 1 for the position built-in since in Vulkan it counts towards the limit but not in our spec. |
Kangz
approved these changes
Oct 3, 2025
kainino0x
approved these changes
Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.