Skip to content

Make rg11b10ufloat-renderable also allow resolving #3834

Merged
kainino0x merged 2 commits intogpuweb:mainfrom
kainino0x:rg11b10ufloat-resolve
Mar 8, 2023
Merged

Make rg11b10ufloat-renderable also allow resolving #3834
kainino0x merged 2 commits intogpuweb:mainfrom
kainino0x:rg11b10ufloat-resolve

Conversation

@kainino0x
Copy link
Copy Markdown
Contributor

@kainino0x kainino0x commented Feb 16, 2023

Fixes #3566

@kainino0x kainino0x force-pushed the rg11b10ufloat-resolve branch from 68d5a43 to 3c2ce4a Compare February 16, 2023 21:09
@kainino0x kainino0x marked this pull request as ready for review February 16, 2023 21:10
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 16, 2023

Previews, as seen when this build job started (49c6642):
WebGPU webgpu.idl | Explainer | Correspondence Reference
WGSL grammar.js | wgsl.lalr.txt

@kainino0x
Copy link
Copy Markdown
Contributor Author

Apparently I forgot to send this to anyone for review, oops.

@kainino0x kainino0x requested a review from toji March 7, 2023 23:26
@kainino0x kainino0x added the copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.) label Mar 7, 2023
@kainino0x kainino0x added this to the V1.0 milestone Mar 7, 2023
Copy link
Copy Markdown
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kainino0x kainino0x merged commit e0282f5 into gpuweb:main Mar 8, 2023
@kainino0x kainino0x deleted the rg11b10ufloat-resolve branch March 8, 2023 20:16
@kainino0x kainino0x added the needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet label Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.) needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rg11b10ufloat-renderable should probably allow use as a resolve target

2 participants