Skip to content

[editorial] Check all destroyable resources at submit() #3645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kainino0x merged 1 commit into from
Nov 30, 2022
Merged

[editorial] Check all destroyable resources at submit() #3645

kainino0x merged 1 commit into from
Nov 30, 2022

Conversation

@kainino0x
Copy link
Contributor

@kainino0x kainino0x commented Nov 29, 2022

No description provided.

@kainino0x kainino0x added the copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.) label Nov 29, 2022
@kainino0x kainino0x added this to the V1.0 milestone Nov 29, 2022
@kainino0x kainino0x requested a review from toji November 29, 2022 00:10
@kainino0x kainino0x mentioned this pull request Nov 29, 2022
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2022

Previews, as seen when this build job started (3bb5dd5):
WebGPU webgpu.idl | Explainer | Correspondence Reference
WGSL grammar.js | wgsl.lalr.txt

toji
toji approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kainino0x kainino0x merged commit 0408170 into gpuweb:main Nov 30, 2022
@kainino0x kainino0x deleted the destroyed-checks branch November 30, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toji toji toji approved these changes

Assignees

No one assigned

Labels

copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.)

Projects

None yet

Milestone

Milestone 0

Development

Successfully merging this pull request may close these issues.

2 participants

@kainino0x @toji