Skip to content

Use task sources for device events and canvas texture expiry #3632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kainino0x merged 3 commits into from
Dec 30, 2022
Merged

Use task sources for device events and canvas texture expiry #3632

kainino0x merged 3 commits into from
Dec 30, 2022

Conversation

@kainino0x
Copy link
Contributor

@kainino0x kainino0x commented Nov 24, 2022

  • Better define device loss, define task source for content timeline steps
  • Define automatic expiry of canvas textures using a task source

Fixes #3295

@kainino0x kainino0x added tacit resolution candidate Editors may be able to resolve and move to tacit resolution queue needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet labels Nov 24, 2022
@kainino0x kainino0x added this to the V1.0 milestone Nov 24, 2022
@kainino0x kainino0x mentioned this pull request Nov 28, 2022
Merged
@github-actions

This comment was marked as outdated.

Sign in to view
@kainino0x kainino0x requested a review from toji November 29, 2022 00:02
toji
toji approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a minor concern about the non-normative text.

@kainino0x kainino0x removed the tacit resolution candidate Editors may be able to resolve and move to tacit resolution queue label Dec 12, 2022
@toji toji mentioned this pull request Dec 12, 2022
Closed
@kainino0x kainino0x added tacit resolution queue Editors have agreed and intend to land if no feedback is given copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.) and removed tacit resolution queue Editors have agreed and intend to land if no feedback is given labels Dec 12, 2022
@kainino0x kainino0x enabled auto-merge (squash) December 30, 2022 02:55
@kainino0x kainino0x merged commit 17fe174 into gpuweb:main Dec 30, 2022
@kainino0x kainino0x deleted the task-sources branch December 30, 2022 02:57
shrekshao
shrekshao reviewed Mar 6, 2023
View reviewed changes
This was referenced Mar 7, 2023
Closed
Open
kainino0x added a commit that referenced this pull request Mar 8, 2023
@kainino0x
Fix tiny typo
00e4b40 
found in
#3632 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shrekshao shrekshao shrekshao left review comments

@toji toji toji approved these changes

Assignees

No one assigned

Labels

copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.) needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet

Projects

None yet

Milestone

Milestone 0

Development

Successfully merging this pull request may close these issues.

Canvas texture expiry timing is unpredictable

3 participants

@kainino0x @toji @shrekshao