Don't trail with empty BGLs in default pipeline layout#3505
Merged
kainino0x merged 1 commit intogpuweb:mainfrom Oct 6, 2022
Merged
Don't trail with empty BGLs in default pipeline layout#3505kainino0x merged 1 commit intogpuweb:mainfrom
kainino0x merged 1 commit intogpuweb:mainfrom
Conversation
The default pipeline layout algorithm should only output BGLs up to the highest `group` index used, rather than up to the maximum. Without this, draw/dispatch would require setBindGroup for all 4 groups, even if you use fewer.
Contributor
|
Previews, as seen when this build job started (6325a3d): |
7 tasks
Kangz
approved these changes
Oct 5, 2022
Contributor
Author
|
Tacit resolution period is not over yet, but landing tentatively so I can keep editing with this landed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default pipeline layout algorithm should only output BGLs up to the highest
groupindex used, rather than up to the maximum.Without this, draw/dispatch would require setBindGroup for all 4 groups, even if you use fewer.
This is related to issue #2043, but I think only holes in the middle of the layout are an open question.