Skip to content

Give fillBuffer() a value argument#2290

Closed
litherum wants to merge 1 commit intogpuweb:mainfrom
litherum:fillBuffer2
Closed

Give fillBuffer() a value argument#2290
litherum wants to merge 1 commit intogpuweb:mainfrom
litherum:fillBuffer2

Conversation

@litherum
Copy link
Copy Markdown
Contributor

@litherum litherum commented Nov 11, 2021 •
edited by pr-preview bot
Loading

Fixes #2278.

Preview | Diff

@litherum litherum requested review from kainino0x and kvark November 11, 2021 01:32
@litherum litherum mentioned this pull request Nov 11, 2021
Closed
@jeronimosg jeronimosg mentioned this pull request Nov 13, 2021
Merged
kvark
kvark requested changes Nov 24, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2278 (comment)

@Kangz
Copy link
Copy Markdown
Contributor

Kangz commented Dec 22, 2021

Closing since the group went with clearBuffer.

@Kangz Kangz closed this Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kvark kvark kvark requested changes

@kainino0x kainino0x Awaiting requested review from kainino0x

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ensure extending fillBuffer is feature detectable

3 participants

@litherum @Kangz @kvark