Merged
Conversation
Fixes gpuweb#1556 * Allows identifiers to be reused so long as the end of the scope is different * practically, this works very much like c-style scoping * one difference is that a function parameter can shadow its function's name * add examples * function names no longer must be unique * clarify scope of function parameters * remove a duplicated note
Contributor
kvark
approved these changes
Mar 25, 2021
Contributor
kvark
left a comment
There was a problem hiding this comment.
I thought we are going to stop on allowing the locals to shadow globals.
But this goes way further.
Contributor
Author
|
I thought we had consensus on this level, but not intra-scope shadowing. In any event, we can modify this if necessary. |
dneto0
requested changes
Mar 26, 2021
Contributor
dneto0
left a comment
There was a problem hiding this comment.
This is really tidy.
Some typos, and a minor fix is required.
* Fix typos * Update scope to potentially denote associated objects * Clarify name resolution * add a new definition for resolves * remove bad link
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1556
different
function's name