Merged
Conversation
Contributor
Contributor
kvark
approved these changes
Feb 19, 2021
Contributor
dneto0
requested changes
Apr 7, 2021
wgsl/index.bs
Outdated
| <thead> | ||
| <tr><th>Type<th>Description | ||
| </thead> | ||
| <tr><td>atomic<*T*><td>Atomic of type *T*. *T* must be either [=u32=] or [=i32=]. |
Contributor
There was a problem hiding this comment.
nit: Suggest using 'algorithm', so you can use |T| to denote a type variable. Clicking on that will highlight all the uses in the same algorithm scope.
<tr algorithm="atomic type"><td>atomic<|T|><td>Atomic of type |T|. ....
Fixes gpuweb#1360 * Adds an atomic type * restricted to i32 and u32 types * Adds atomic built-in functions * atomicLoad * atomicStore * atomicAdd * atomicMax * atomicMin * atomicAnd * atomicOr * atomicXor * atomicExchange * atomicCompareExchangeWeak
* Improve descriptions of synchronization guarantees * fix example * editorial fixes
dneto0
approved these changes
Apr 8, 2021
Contributor
dneto0
left a comment
There was a problem hiding this comment.
approve with nit about extra words. Can patch that later.
| integral constant in SPIR-V for all `Memory Semantics` operands). | ||
| This means synchronization and ordering guarantees only apply among atomic | ||
| operations acting on the same [=memory locations=]. | ||
| No synchronization or ordering guarantees are made apply between atomic and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1360