Merged
Conversation
Contributor
Author
|
Ran locally in dawn.node and fixed what I saw. Running here https://dawn-review.googlesource.com/c/dawn/+/245034 to test on browser. |
8 tasks
Contributor
Author
|
Also, it's not clear from the spec I think, either WGSL is supposed to allow these formats by default. For example, WGSL allows
As it is, a few tests here and there currently fail with WGSL compilation errors for these formats. I feel like WGSL should allow these, same as it allows |
Collaborator
|
Agree it should work the same as |
kainino0x
approved these changes
Jun 3, 2025
This pulls in new formats for feature 'texture-formats-tier1' which required updates to format_info.ts, capability_info.ts and several tests. Note: Since no implementation actually supports 'texture-formats-tier1' yet it's very possible some tests will need fixes when the feature is implemented.
27a5e58 to
ab6b326
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pulls in new formats for feature 'texture-formats-tier1' which required updates to format_info.ts, capability_info.ts and several tests.
Note: Since no implementation actually supports 'texture-formats-tier1' yet it's very possible some tests will need fixes when the feature is implemented.