Skip to content

Conversation

@zoddicus
Copy link
Contributor

Also remove usage of this infra by integer tests that shouldn't have
been using it to begin with.

Fixes #792


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

Also remove usage of this infra by integer tests that shouldn't have
been using it to begin with.

Fixes gpuweb#792
@zoddicus zoddicus added the wgsl label Jul 18, 2022
@zoddicus zoddicus requested review from ben-clayton, dj2 and dneto0 July 18, 2022 18:56
@zoddicus zoddicus self-assigned this Jul 18, 2022
@github-actions
Copy link

Previews, as seen when this build job started (d2bd43f):
Run tests | View tsdoc

@zoddicus zoddicus merged commit 4786c28 into gpuweb:main Jul 18, 2022
@zoddicus zoddicus deleted the removeOldFPFramework branch July 18, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How should accuracy of floating point builtins be evaluated?

2 participants