-
Notifications
You must be signed in to change notification settings - Fork 100
Implement new F32Interval class for floating point tests #1500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This implements the F32Interval class and fundamental accuracy functions described in my prototype for reworking, gpuweb#1402, how floating point tests are written. This also adds in testing that did not appear in my prototype. There are a couple of functions that are not currently used that I have included in this patch that have suppressions for unused-vars on them. I included them in this patch since they are logically grouped with this code. These supressions will be removed in future patches. Issue gpuweb#792
|
Previews, as seen when this build job started (37fc7a3): |
|
Previews, as seen when this build job started (36c61e2): |
|
PTAL |
ben-clayton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About 30% through reviewing. More to come...
This fixes a subtle bug in how oneULP was being calculated.
|
Previews, as seen when this build job started (f5cafe6): |
ben-clayton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for all the responses and fix.
|
Previews, as seen when this build job started (0212874): |
This implements the F32Interval class and fundamental accuracy
functions described in my prototype for reworking,
#1402, how floating point tests are
written.
This also adds in testing that did not appear in my prototype.
There are a couple of functions that are not currently used that I
have included in this patch that have suppressions for unused-vars on
them. I included them in this patch since they are logically grouped
with this code. These supressions will be removed in future patches.
Issue #792
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.