Skip to content

Conversation

@zoddicus
Copy link
Contributor

@zoddicus zoddicus commented Jun 1, 2022

This implements the F32Interval class and fundamental accuracy
functions described in my prototype for reworking,
#1402, how floating point tests are
written.

This also adds in testing that did not appear in my prototype.

There are a couple of functions that are not currently used that I
have included in this patch that have suppressions for unused-vars on
them. I included them in this patch since they are logically grouped
with this code. These supressions will be removed in future patches.

Issue #792


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

This implements the F32Interval class and fundamental accuracy
functions described in my prototype for reworking,
gpuweb#1402, how floating point tests are
written.

This also adds in testing that did not appear in my prototype.

There are a couple of functions that are not currently used that I
have included in this patch that have suppressions for unused-vars on
them. I included them in this patch since they are logically grouped
with this code. These supressions will be removed in future patches.

Issue gpuweb#792
@zoddicus zoddicus added the wgsl label Jun 1, 2022
@zoddicus zoddicus requested review from ben-clayton, dj2 and dneto0 June 1, 2022 20:47
@zoddicus zoddicus self-assigned this Jun 1, 2022
@github-actions
Copy link

github-actions bot commented Jun 1, 2022

Previews, as seen when this build job started (37fc7a3):
Run tests | View tsdoc

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

Previews, as seen when this build job started (36c61e2):
Run tests | View tsdoc

@zoddicus
Copy link
Contributor Author

zoddicus commented Jun 2, 2022

PTAL

Copy link
Contributor

@ben-clayton ben-clayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About 30% through reviewing. More to come...

This fixes a subtle bug in how oneULP was being calculated.
@github-actions
Copy link

github-actions bot commented Jun 6, 2022

Previews, as seen when this build job started (f5cafe6):
Run tests | View tsdoc

@zoddicus zoddicus requested a review from ben-clayton June 6, 2022 21:16
Copy link
Contributor

@ben-clayton ben-clayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for all the responses and fix.

@zoddicus zoddicus merged commit 9474c0e into gpuweb:main Jun 7, 2022
@zoddicus zoddicus deleted the implementF32Interval branch June 7, 2022 18:13
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

Previews, as seen when this build job started (0212874):
Run tests | View tsdoc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants