fix: add missing sound files to package distribution#969
Merged
Conversation
Fixes #964 The sound files (bell.wav, etc.) are generated by scripts/generate_sounds.py but were not included in the package distribution, causing warnings when users ran /setup. Changes: - Generate and include all 8 sound files in media/ - Update pyproject.toml to include media/*.wav in package Sound files included: - bell.wav (notification bell) - chime.wav (alternative notification) - sawing.wav, drilling.wav (tool use sounds) - page_turn.wav (read operations) - seashell_click.wav (shell commands) - camera_shutter.wav (screenshots) - file_write.wav (file operations)
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to c624f04 in 32 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
8files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. pyproject.toml:31
- Draft comment:
Including .wav files in the package resolves #964. Also note that the PNG pattern was changed from a specific file (logo.png) to *.png; confirm this is intentional. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_7Mh3pCVTCZR2y19g
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #964 - Bell sound file not found during /setup
Problem
When users ran
/setup, they got a warning:The sound files are generated by
scripts/generate_sounds.pybut were not:Changes
Generated all 8 sound files using
scripts/generate_sounds.py:Updated pyproject.toml to include
media/*.wavin package distribution alongsidemedia/*.pngTesting
Important
Fixes missing sound files issue by generating them and updating
pyproject.tomlto includemedia/*.wavin package distribution./setupby generating 8 sound files usingscripts/generate_sounds.py.pyproject.tomlto includemedia/*.wavin package distribution.pyproject.toml: Addsmedia/*.wavto theincludesection for package distribution.This description was created by
for c624f04. You can customize this summary. It will automatically update as commits are pushed.