Skip to content

Fix warning on non-200 status codes in coverart #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
elelay merged 1 commit into from
Mar 5, 2021
Merged

Fix warning on non-200 status codes in coverart #970

elelay merged 1 commit into from
Mar 5, 2021

Conversation

@paper42
Copy link
Contributor

@paper42 paper42 commented Mar 5, 2021

before:

[gpodder.coverart] WARNING: Cannot save cover art
Traceback (most recent call last):
  File "/home/michal/build/gpodder/src/gpodder/coverart.py", line 103, in get_cover
    raise ValueError(msg)
ValueError: Unknown file type: <URL> (b'')

after:

[gpodder.coverart] WARNING: Cover art download failed: <URL> returned status code 404

@elelay elelay merged commit 2d262dc into gpodder:master Mar 5, 2021
@elelay
Copy link
Member

elelay commented Mar 5, 2021

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paper42 @elelay