Skip to content

Conversation

@auouymous
Copy link
Member

Extensions can return [] to hide a menu item, but making it insensitive is less confusing than hiding it. The first patch allows extensions to disable menu items by returning None for the callback.

Closes #958.

@elelay
Copy link
Member

elelay commented Feb 13, 2021

That's nice!

@elelay elelay merged commit 43a82d6 into gpodder:master Feb 13, 2021
@elelay
Copy link
Member

elelay commented Feb 13, 2021

Merged, thanks.
Returning a None callback to mean disable is perfect for retro-compatibility and elegant.

@auouymous auouymous deleted the open-website-label branch February 13, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Open website" menu link is always enabled for each podcast episode, even if there's no website

2 participants