Skip to content

Conversation

@paper42
Copy link
Contributor

@paper42 paper42 commented Feb 6, 2021

No description provided.

@auouymous
Copy link
Member

Prefs...General:

  • horizontal gaps around combo boxes are wider, which now matches the margin (nice)
  • but there is no vertical gap between the two combo boxes

Prefs...gpodder.net:

  • looks better

Prefs...Updating:

  • no changes, but should probably get wider horizontal gaps like the other tabs

Prefs...Clean-up:

  • same as the Updating tab

Prefs...Devices:

  • the first two rows lack the wider gap which the other two labels have
  • mountpoint is the only indented/aligned label

@paper42 paper42 force-pushed the remove-deprecated-gtk-elements branch from 2ce4f80 to ca1c554 Compare February 15, 2021 15:43
@paper42
Copy link
Contributor Author

paper42 commented Feb 15, 2021

Prefs...Devices:

  • mountpoint is the only indented/aligned label

I am not sure what you mean by that. Is it fixed now?

Other than that, I think I managed to address all your points. Thank you for them.

@auouymous
Copy link
Member

The update interval slider in Prefs...Updating is still missing a wider gap.

In Prefs...Devices, device type and mountpoint are in a grid with the labels aligned to the right side of the column. Add a bunch of characters to the device type or mountpoint labels to better see the issue.

@paper42
Copy link
Contributor Author

paper42 commented Feb 15, 2021

Thanks, fixed.

@paper42 paper42 force-pushed the remove-deprecated-gtk-elements branch from 2cec183 to 1304209 Compare February 15, 2021 17:13
@auouymous
Copy link
Member

It now looks like device type and mountpoint are centered in the column, is it not possible to left align those two?

@auouymous
Copy link
Member

Adding <property name="xalign">0</property> before the device type and mountpoint labels fixes the problem.

<property name="visible">True</property>
<property name="xalign">0</property>
<property name="label" translatable="yes">Device type:</property>
...
<property name="visible">True</property>
<property name="xalign">0</property>
<property name="label" translatable="yes">Mountpoint:</property>

@paper42 paper42 force-pushed the remove-deprecated-gtk-elements branch from 1304209 to 9451d2f Compare March 1, 2021 19:17
@paper42
Copy link
Contributor Author

paper42 commented Mar 1, 2021

I am so sorry for the delay, I fixed it. Thanks for your patience.

@auouymous
Copy link
Member

LGTM.

@elelay Are you okay with the new padding and alignment changes?

@elelay
Copy link
Member

elelay commented Mar 2, 2021

Great, thanks

@elelay elelay merged commit 3c17d2b into gpodder:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants