Add more episode details to shownotes #934
Conversation
|
Good idea! It seems maybe a bit crowded. |
|
Here is a screenshot on my desktop: What do you think? It adds an unwanted line of contents for users with a square-ish display, but I see how it would fit a narrow display with all optional columns hidden. |
8520568 to
521e6ea
Compare
|
The SailfishOS version of gPodder 4 has the episode details on the shownotes formatted like '2021-04-28 | 100.0 MiB | 35:00'. I updated (and rebased) this PR to use this format and print the details with a smaller font. I'm going to use this on the adaptive branch, but it would be nice to have this everywhere. |
|
Looks good 👍
|
|
LGTM, but 0.8 is too small to read. 0.9 is readable. |
521e6ea to
deb21aa
Compare
|
I changed the scale to 0.9 and rebased. |
|
The columns use a hyphen for duration and nothing for size when they are unknown. Should this do something similar? |
yes, it would be better |
deb21aa to
fbf59cf
Compare
|
The formatting is now the same as in columns. I'm somewhat itching to replace the "" for unknown size with a "-" though. |
|
I agree with the "-", it looks better with or without a duration. |
fbf59cf to
9208a98
Compare
|
Unknown size is now displayed as "-". |
Add a line after subheading in shownotes with episode release date, length and size.
9208a98 to
124d7b3
Compare
|
Also added html.escape() to the HTML version. |
|
Merged, thanks 👍 |
|
What about the unresolved if-else code review? |
Add a line after subheading in shownotes with episode release date, length and size.
I usually have just the 'Released' column visible in the episode list TreeView, so having these visible in the shownotes is useful.
The formatting and the items in the details can be discussed in this PR and changed accordingly.