Refactor shownotes #931
Refactor shownotes #931
Conversation
|
I can't test with HTML shownotes but it works fine with text shownotes. The header always scrolled in text shownotes and HTML shownotes should do the same, so I agree with this PR. The new information should probably be in a separate PR since it has nothing to do with scrolling the header. I don't like the period after the channel name and size. Why was |
Use GtkOverlay to show link destination in both HTML and text shownotes. Remove GtkTextView from HTML shownote pane and write a HTML header from episode title and other data. The title section now scrolls with the rest of the description text. Plain text descriptions are converted to HTML by adding <br> tags on newlines.
|
I removed the extra episode details from shownotes. I'll make a separate PR for them if or when this one gets merged, as suggested. |
|
Thanks, text shownotes still work fine with the patch. |
|
Thanks: looks good while playing with the UI. I'll review the code later :-) |
|
Merged, thanks! |
Currently the header part of the HTML shownotes is attached to the top of the pane and not scrolled with the rest of the description. This wastes space and is annoying on small screens and short panes.
This patch makes the full HTML shownote pane scrollable by converting the header content which was in a separate GtkTextView widget to HTML and using a single WebView. It also unifies TextView and HTML shownote versions to use a GtkOverlay for showing link destinations. The title section also shows more episode details and uses non-breakable spaces between values and units etc.