Do not show new episodes on view->Downloaded #897
Conversation
|
Thanks for the patch. See #468 (comment) for proposal to add a checkbox "always show new episodes" in combination with this. |
bf9fa8c to
16c65e7
Compare
|
Ok, I implemented the checkbox. It works for me but please test. |
elelay
left a comment
There was a problem hiding this comment.
I haven't tested it yet but it looks fine!
Just change the one remark.
I want to push a new release this week and already polled translators for updates so I won't merge your PR just now.
It will be merged next week, though.
Thanks,
src/gpodder/gtkui/model.py
Outdated
| tooltip.append(_('New episode')) | ||
| view_show_downloaded = True | ||
| if self._config.ui.gtk.episode_list.always_show_new: | ||
| view_show_downloaded = True |
There was a problem hiding this comment.
Replace by view_show_downloaded = self._config.ui.gtk.episode_list.always_show_new
Maybe store self._config.ui.gtk.episode_list.always_show_new in a variable at the start of the loop.
There was a problem hiding this comment.
Good catch, I've pushed a fixed version.
16c65e7 to
d9ada60
Compare
elelay
left a comment
There was a problem hiding this comment.
perfect, thanks.
Just make it checked by default for backward compatibility.
Adds a new boolean config item ui.gtk.episode_list.always_show_new, which can be toggled from menu with View->Always show New episodes. If set, the Downloaded episodes view also shows new episodes.
d9ada60 to
b73282b
Compare
|
Great, thanks! |
|
Merged, thanks |
Add 'Always show New episodes' toggle to View menu
Fixes #468.
Adds a new boolean config item ui.gtk.episode_list.always_show_new, which can be toggled from menu with View->Always show New episodes.
If set, the Downloaded episodes view also shows new episodes.