Optimize episode list #1435
Merged
Optimize episode list #1435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can decrease episode list update time by 1.7%.
This can decrease episode list update time by 0.2%.
This can decrease episode list update time by 1.5%.
And concatenate episode fields instead of iterating over them. Simplifies the expression and can decrease episode list update time by 0.2%.
This can decrease episode list update time by 0.2%.
The UI is still responsive while performing more work per interval and updating the list in 90% of the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches improve episode list refresh time by about 12%. Additional optimizations in
get_update_fields()could improve it more but half of the time is spent in themodel.set()call.The themed Gio icon check increases the time spent in
get_update_fields()by 24% for downloaded episodes. There was talk in #872 about removing those icons.