Fix the format_time() function to display times greater than 24 hours. #1398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
319cf76 to
48d196e
Compare
tpikonen
reviewed
Sep 16, 2022
Contributor
|
Where do you need time strings where the hour is > 23? |
48d196e to
1a01f5c
Compare
tpikonen
reviewed
Sep 17, 2022
Using datetime converts the seconds value into date and time components. A value of 86400 generates a 00:00 time on the 2nd of January 1970. The new code properly increments the hour field to 24 and beyond instead of wrapping around to zero.
1a01f5c to
2659333
Compare
Contributor
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using datetime converts the seconds value into date and time components. A value of 86400 generates a 00:00 time on the 2nd of January 1970.
The new code properly increments the hour field to 24 and beyond instead of wrapping around to zero. The left-most zero for hour or minute field is now dropped to make episode times easier to read.