Don't try to download media files with youtube-dl extension #1383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Oops, I merged #1381 before looking at this and now it has conflicts. |
ace49d9 to
c198180
Compare
Contributor
Author
|
Rebased to master, added comment. |
Member
|
LGTM, I'll wait a week to see if anything breaks. |
Member
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another try at detecting direct media file links fed to the youtube-dl extension. Uses functions from
util.pyto check if the link has something that looks like a file extension and whether it is from a known media file.Fixes audioboom feeds with youtube-dl download enabled (#1263) and seems not to break anything else, although thorough testing before merging should be in order this time.