Reset window position if completely off-screen. #1356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Or maybe at least 1/4 to 1/2 of the width and height to be visible. |
4804bd6 to
5cef757
Compare
Member
Author
|
I changed it to reset if more than 50% of the window is off-screen, so enough is visible to see it. I double anyone has 50% of the window off-screen because it is unlikely that even narrow windows would be usable with only 50% visible. |
elelay
approved these changes
Aug 22, 2022
Member
elelay
left a comment
There was a problem hiding this comment.
LGTM.
minor syntax change to make it more concise
5cef757 to
3a4cd02
Compare
Member
|
Merged, thanks |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires one pixel of any side of the window to be on-screen, or it resets the position to default. It might be more useful if it required ten or more pixels so the window would be more visible.
Fixes #1352.