Don't try to download media files with youtube-dl extension #1347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the fix. |
This was referenced Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gPodder calls
registry.custom_downloader.resolvefor every episode/URL when a download is attempted. Some episode URLs which youtube-dl / yt-dlp claims to support are direct media links, and at least yt-dlp is buggy so that it does not in fact download anything when given such an URL. At least spreaker.com (bug #1263) and audioboom.com fail this way.Change the youtube-dl extension so that it does not support episodes where the MIME type is
audio/*orvideo/*. These episodes are then downloaded with the default downloader.Fixes #1263.